Review of "Brightness Restore" version 1 (1)

Details Page Preview

Restores brightness on login and provides persistent software brightness control for external monitors. Latest Update (v2) Dual UI Modes: Quick Settings (Default): Integrated seamlessly into the status area pill (no slider, clean look). Standalone: Classic panel button with slider menu for direct control. Hybrid Hardware/Software Control: Prioritizes org.gnome.SettingsDaemon.Power (DBus) for hardware control. Automatically falls back to Main.brightnessManager (Software) if hardware is unavailable. Preferences Refinement: Reordered settings for better usability. Conditional visibility for position settings based on selected style. Conditional Watchdog: Background monitoring process now only runs when "Debug Mode" is enabled. Robustness: Fixed linting issues and duplicate code paths. Cleanup: Removed unused artifacts and legacy battery/power components. Refactor: Split monolithic UI logic into focused indicator modules for maintainability.

Extension Homepage
https://github.com/DarkPhilosophy/brightness-restore

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 (2) Rejected
1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't store any instance of objects in a property in the default class you are exporting (line 63 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to move that local, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Use the instance that already created in the entry point (line 18 `extension.js`): ```js this._settings = extension._settings; ```` 3. Better to remove line 187 `library/utils.js` and only create it where you are using it or make it a function so it is not in global scope.
AdalbertAlexandru posted a review
Sorry... it seems this would more "polish" to be done, give me a few minutes to fix all the issues.