Review of "Brightness Restore" version 2 (2)

Details Page Preview

Restores brightness on login and provides persistent software brightness control for external monitors.

Extension Homepage
https://github.com/DarkPhilosophy/brightness-restore

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 (3) Active
2 (2) Rejected
1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. What's the reason for `dummyPrefsPage` (line 46-47 `prefs.js`)? And what kind of log spamming are you mentioning in that comment? 2. Please fix line 187 `library/utils.js` as mentioned before. 3. IMO, the logger you are using in `library/logger.js` is too much. You don't need to log everything in a file. Linux users should be able to read the logs with no issues. 4. No need to wrap in try-catch (line 41, 85 `library/indicators/quick-settings.js`).
JustPerfection posted a review
Also, please avoid adding changelog to the description.
AdalbertAlexandru posted a review
Is not too much as is just opt-in only of logtofile, by default all logs go to journald (standard for Linux behavior). while the file logging is kept for advanced users who explicitly enable to cache/, but able to set to /tmp/ as I used myself for logging. I saw adwaita keep complaining when a PreferencesWindow has no Adw.PreferencesPage attached so I used a dummy page in order to satisfy the log noise.... I've notice others are using same method but didn't look into it if if there is a better solution so I'll remove the dummy page and attach the first real page to the window to avoid the Adw warnings. I use a .sh script to update the .zip, I didn't knew it keep the old files so I'll fix this utils.js