Review of "Kiwi is not Apple" version 1.5.4 (37)

Details Page Preview

### Note. EGO review delays ### The GNOME Extensions website is currently experiencing delays in reviewing and approving submissions, resulting in a significant backlog. To use extension latest version 1.6.0 follow instructions on GitHub page: https://github.com/kem-a/kiwi-kemma/releases/tag/v1.6.0 -------------------------------- Kiwi is free open source project that brings macOS-inspired features for GNOME. *Note. This extension is tested with vanilla GNOME Adwaita theme. Be aware that other extensions may cause compatibility issues. Features: - macOS-style window control buttons with GTK theming - Firefox and Thunderbird window control theming - Move fullscreen windows to new workspaces automatically - Make windows transparent while moving - Display battery percentage when below 20% - Move calendar to the right side and customize notifications - Quick settings media and notifications tweaks - Show current window title in the top panel - Show panel on hover in fullscreen mode - Hide minimized windows in overview - Hide the Activities button - Skip overview on login (go directly to desktop) - Set panel transparency or blur effect based on window position - Dash-to-dock blur effect - Overview wallpaper blur - Keyboard indicator styling - Focus on newly launched windows (removes window-ready notifications) - Show Caps Lock/Num Lock indicators in the top panel - Add username display to the quick settings menu - Multilingual support and more... This extension uses a modular architecture for stability and customization. Some advanced features require native libraries (available in the advanced/ folder). Disclaimer: This extension is unofficial and not affiliated with Apple in any way.

Extension Homepage
https://github.com/kem-a/kiwi-kemma

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
1.5.5 (41) Active
1.5.5 (40) Rejected
1.5.5 (39) Rejected
1.5.4 (38) Inactive
1.5.4 (37) Rejected
1.5.3 (36) Active
1.5.3 (35) Rejected
1.5.2 (34) Active
1.5.1 (33) Active
1.5.0 (32) Inactive
1.4.1 (31) Active
1.4.1 (30) Rejected
1.4.0 (29) Active
1.4.0 (28) Rejected
1.3.1 (27) Active
1.3.0 (26) Active
1.2.1 (25) Active
1.2.1 (24) Rejected
1.2.0 (23) Active
1.1.0 (22) Active
1.0.2 (21) Inactive
1.0.1 (20) Inactive
1.0.0 (19) Inactive
18 Inactive
17 Inactive
16 Rejected
15 Inactive
0.9.6 beta (14) Rejected
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Nothing throws in line 331 `apps/overviewWallpaper.js`. Same in other lines. Remove all unnecessary try-catch wrappers and send it again.
Arnis K posted a review
Well, it's hard to judge what is necessary and what is not. I don't know every method or class by heart if it have built in error handling mechanism. Many, also empty, try/catch blocks are defensive to potential prevent shell crash or some failures on destroy() or disconnect(). The same applies to l331 in `overviewWallpaper.js`. The catch ensures the function continues to load the new stylesheet even if unloading the old one fails. Without it, a failure would abort the entire function, preventing the new wallpaper from being applied. If you still insist, I can remove it.
JustPerfection posted a review
`destroy()` and `disconnect()` should never throw. Same for `unload_stylesheet()`.
Arnis K posted a review
What about `GLib.Source.remove() and `GLib.source_remove()`. try/catch can be removed?
JustPerfection posted a review
Same. They never throw. If you remove a signal that has been removed before, it only gives a warning. You should always null out the property holding the signal id in the callback when the callback returns `SOURCE_REMOVE`.