EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• apps/batteryPercentage.js:94

                          this._propertiesChangedId = this._batteryProxy.connect('g-properties-changed', () => {
                              this._updateBatteryPercentage();
                          })

• apps/windowControls.js:84

          this._box.connect('leave-event', () => {
              this._isContainerHovered = false;
              this._updateAllIcons();
              return Clutter.EVENT_PROPAGATE;
          })

• apps/windowControls.js:75

          this._box.connect('motion-event', () => {
              if (this._suppressHoverUntilPointerMove) {
                  this._suppressHoverUntilPointerMove = false;
                  this._updateAllIcons();
              }
              return Clutter.EVENT_PROPAGATE;
          })

• apps/windowControls.js:149

          this._closeButton.connect('clicked', () => {
              const window = global.display.focus_window;
              if (window) window.delete(global.get_current_time());
          })

• apps/windowControls.js:124

          this._maximizeButton.connect('clicked', () => {
              const window = global.display.focus_window;
              if (window) {
                  if (window.is_fullscreen()) {
                      window.unmake_fullscreen();
                  } else if (window.maximized_horizontally && window.m

• apps/windowControls.js:119

          this._minimizeButton.connect('clicked', () => {
              const window = global.display.focus_window;
              if (window) window.minimize();
          })

• apps/windowControls.js:93

              button.connect('button-press-event', () => {
                  button.add_style_pseudo_class('active');
                  this._updateButtonIcon(buttonType);
              })

• apps/windowControls.js:97

              button.connect('button-release-event', () => {
                  button.remove_style_pseudo_class('active');
                  this._updateButtonIcon(buttonType);
              })

• apps/windowControls.js:102

              button.connect('enter-event', () => {
                  if (this._suppressHoverUntilPointerMove) {
                      this._suppressHoverUntilPointerMove = false;
                  }
                  if (this._useMacosIcons) {
                      this._isContainerHovered = true;
              

• apps/windowControls.js:111

              button.connect('leave-event', () => {
                  if (this._useMacosIcons) {
                      this._isContainerHovered = false;
                      this._updateAllIcons();
                  }
              })

• apps/windowControls.js:92

  button.connect('notify::hover', () => this._updateButtonIcon(buttonType))

• apps/windowTitle.js:54

          this._menu.connect('open-state-changed', (menu, isOpen) => {
              if (isOpen) {
                  this._updateRestoreMenuItem();
                  GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                      this._syncMenuAlignment();
                      return GLib.SOURCE_REMOVE;
     

EGO014 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• apps/batteryPercentage.js:15

          this._batteryLabel = new St.Label({
              style_class: 'battery-percentage-label',
              text: '',
              opacity: 0,
              y_align: Clutter.ActorAlign.CENTER
          })

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• apps/batteryPercentage.js:15

          this._batteryLabel = new St.Label({
              style_class: 'battery-percentage-label',
              text: '',
              opacity: 0,
              y_align: Clutter.ActorAlign.CENTER
          })

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• apps/mozillaThemeManager.js:278

  file.load_contents(null)

• apps/overviewWallpaper.js:110

  file.load_contents(null)

• apps/overviewWallpaper.js:151

  file.load_contents(null)

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• apps/windowTitle.js:151

          GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
              this._syncMenuAlignment();
              return GLib.SOURCE_REMOVE;
          })

• apps/windowTitle.js:57

                  GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                      this._syncMenuAlignment();
                      return GLib.SOURCE_REMOVE;
                  })