Review of "Dock Window Preview" version 1

Details Page Preview

Preview open windows by hovering a dock icon and activate a window by selecting the preview.


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • Makefile
    Makefile

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:38
            this._actor = new St.BoxLayout({
                style_class: 'dock-preview-popup',
                vertical: true,
                reactive: true,
                can_focus: true,
                track_hover: true,
                visible: false,
            })

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

serendipity posted a review
Looks good
SriramRamkrishna rejected
You have a few issues from the linter shexli. Please use pip3 install shexli and run it against your extension and fix all the output from that and then resubmit.
serendipity posted a review
@SriramRamkrishna Thank you for the review. I've cleaned up all the shexli warning. Can you please review it again?