Panel indicator backed by PackageKit D-Bus with optional fwupd support
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-A-004 warning
extension files should not contain excessive ungated console logging
File contains 11 ungated console.log/warn/error calls (threshold: 5).
Updates Indicator
extension.js:484
console.error(`${UUID}: spawn read error: ${e}`)
extension.js:490
console.error(`${UUID}: spawn error: ${e}`)
extension.js:501
console.error(`${UUID}: failed to save updates file: ${e}`)
extension.js:534
console.error(`${UUID}: update check failed`)
extension.js:255
console.log(`${UUID}: D-Bus Finished – ${this._updates.map.size} updates`)
extension.js:510
console.log(`${UUID}: Skipping refresh – too frequent`)
extension.js:514
console.log(`${UUID}: Refreshing (${refreshMode})...`)
extension.js:551
console.log(`${UUID}: Firmware updates processing finished, updates found: ${fwCount}`)
extension.js:28
console.warn(`${UUID}: deep_unpack failed: ${e}`)
extension.js:48
console.warn(`${UUID}: Unrecognised Package(s) D-Bus payload: ${JSON.stringify(unpacked)}`)
EGO-P-007 warning
JavaScript files should be reachable from extension.js or prefs.js
Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.
Don't include unnecessary files
error-window.js
info-window.js
| Version | Status |
|---|---|
| 1.0.0 (2) | Unreviewed |
| 1 | Rejected |
the shexli linter has a few issues. Please pip3 install shexli and then run it against your extension and fix whatever the output are. If you find some false errors, just let us know that when you resubmit. Thanks.
I would say these are false positives: - "extension files should not contain excessive ungated console logging": most of those messages are logged when error occurs, and the rest when doing an actual update or refresh (every 1 hour by default) - "JavaScript files should be reachable from extension.js or prefs.js": both of those file are used by the "updates.sh" file
Yes, they are false positives but still should be rejected: 1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Remove the timeout on destroy/disable and before creating a new one (line 140 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions