Review of "Updates Indicator" version 1.0.0 (2)

Details Page Preview

Panel indicator backed by PackageKit D-Bus with optional fwupd support

Extension Homepage
https://github.com/zamszowy/gnome-updates-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:254
    console.log(`${UUID}: D-Bus Finished – ${this._updates.map.size} updates`)
  • extension.js:516
    console.log(`${UUID}: Skipping refresh – too frequent`)
  • extension.js:520
    console.log(`${UUID}: Refreshing (${refreshMode})...`)
  • extension.js:557
    console.log(`${UUID}: Firmware updates processing finished, updates found: ${fwCount}`)
  • extension.js:490
    console.error(`${UUID}: spawn read error: ${e}`)
  • extension.js:496
    console.error(`${UUID}: spawn error: ${e}`)
  • extension.js:507
    console.error(`${UUID}: failed to save updates file: ${e}`)
  • extension.js:540
    console.error(`${UUID}: update check failed`)
  • extension.js:28
    console.warn(`${UUID}: deep_unpack failed: ${e}`)
  • extension.js:48
    console.warn(`${UUID}: Unrecognised Package(s) D-Bus payload: ${JSON.stringify(unpacked)}`)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • error-window.js
  • info-window.js

All Versions

Version Status
1.0.0 (2) Unreviewed
1 Rejected