Review of "Wharf" version 2

Details Page Preview

A reliable dock for GNOME.

Extension Homepage
https://codeberg.org/vodofrede/wharf

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:83
    window.connect("position-changed", () => this.queueOverlapCheck())
  • extension.js:89
    window.connect("position-changed", () => this.queueOverlapCheck())
  • extension.js:84
    window.connect("size-changed", () => this.queueOverlapCheck())
  • extension.js:90
    window.connect("size-changed", () => this.queueOverlapCheck())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:366
                            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
                                this.dock.edgeActivated = false;
                                if (!this.dock._dashContainer.get_hover()) {
                                    this.dock.dodge.queueOverlapCheck();
                        

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

SriramRamkrishna rejected
the shexli linter has a few issues. Please pip3 install shexli and then run it against your extension and fix whatever the output are. If you find some false errors, just let us know that when you resubmit. Thanks.