Review of "Wharf" version 3

Details Page Preview

A reliable dock for GNOME.

Extension Homepage
https://codeberg.org/vodofrede/wharf

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:85
    window.connect("position-changed", () => this.queueOverlapCheck())
  • extension.js:91
    window.connect("position-changed", () => this.queueOverlapCheck())
  • extension.js:86
    window.connect("size-changed", () => this.queueOverlapCheck())
  • extension.js:92
    window.connect("size-changed", () => this.queueOverlapCheck())

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

vodofrede posted a review
Both remaining shexli issues are false positives, in my opinion. I have created GNOME GitLab issues for one of them (GSchema), the other already has one. ``` vodofrede@vera ~/Projekter/wharf > uv tool run shexli wharf@vodofrede.shell-extension.zip shexli: issues_found (2 findings, 1 errors, 1 warnings) EGO-P-003 error Extension appears to use GSettings but no `.gschema.xml` file is included in the package. = rule: GSettings schema XML must be present in package = help: GSettings Schemas https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas EGO-L-003 warning Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods. --> wharf@vodofrede.shell-extension.zip:extension.js:85 | | window.connect("position-changed", () => this.queueOverlapCheck()) | = also: wharf@vodofrede.shell-extension.zip:extension.js:91 = also: wharf@vodofrede.shell-extension.zip:extension.js:86 = also: wharf@vodofrede.shell-extension.zip:extension.js:92 = rule: signals connected by extension should be disconnected in disable() = help: Disconnect all signals https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals ```