Review of "Movie Screensaver" version 1

Details Page Preview

Video screensaver for GNOME using a local movie file


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:562
    GLib.file_get_contents(this._markerFile)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:342
    console.error('[MovieScreensaver] Failed to set up idle monitor:', e.message)
  • extension.js:587
    console.error('[MovieScreensaver]', message, videoPath)
  • extension.js:280
    console.warn('[MovieScreensaver] disable: settings disconnect error:', e.message)
  • extension.js:288
    console.warn('[MovieScreensaver] disable: idle watch removal error:', e.message)
  • extension.js:295
    console.warn('[MovieScreensaver] disable: logind disconnect error:', e.message)
  • extension.js:305
    console.warn('[MovieScreensaver] disable: screensaver stop error:', e.message)
  • extension.js:383
    console.warn('[MovieScreensaver] Could not connect to logind:', e.message)
  • extension.js:620
    console.warn('[MovieScreensaver] user_active_watch failed, falling back to stage:', e.message)
  • extension.js:673
    console.warn('[MovieScreensaver] Could not lock screen:', e.message)

All Versions

Version Status
2 Unreviewed
1 Unreviewed