Review of "Simple Clock" version 1

Details Page Preview

A simple custom clock widget

Extension Homepage
https://github.com/devilbd/gnome-extensions/tree/main/analogue-clock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.clock.gschema.xml
    id='org.gnome.shell.extensions.clock@devilbd.com' path='/org/gnome/shell/extensions/clock/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:42
    this._clockWidget.connect('repaint', this._drawClock.bind(this))

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

devilbd posted a review
I just put a new (2) version of the widget with the changes.
fmuellner active