Review of "Tablet Rect" version 1

Details Page Preview

Draw a semi-transparent rectangle on screen to indicate the OpenTabletDriver mapped area

Extension Homepage
https://github.com/LaneSun/tablet-rect

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:316
    file.load_contents(null)
  • extension.js:354
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/tablet-rect.pot
    po/tablet-rect.pot
  • po/zh_CN.po
    po/zh_CN.po

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:112
        this._modeSection = new PopupMenu.PopupSubMenuMenuItem(
          _("Show Mode"),
        )

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:112
        this._modeSection = new PopupMenu.PopupSubMenuMenuItem(
          _("Show Mode"),
        )

All Versions

Version Status
1 Unreviewed

Previous Reviews on this Version

lanesun posted a review
Initial Version