Review "g-time" version 1 - GNOME Shell Extensions

Review of "g-time" version 1

Details Page Preview

g-time

A quick and precise timer for GNOME Shell.

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:239

      valueEntry.clutter_text.connect("activate", () => {
        this._renderTime();
      })

extension.js:245

      valueEntry.clutter_text.connect("key-press-event", (_actor, event) => {
        return this._onValueEntryKeyPress(type, event);
      })

extension.js:242

      valueEntry.clutter_text.connect("text-changed", () => {
        this._onValueEntryChanged(type, valueEntry);
      })

All Versions

Version	Status
1	Unreviewed