EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• extension.js:44

  GLib.file_get_contents(path)

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

• extension.js:375

          GLib.spawn_command_line_sync(
              `sh -c "echo ${governor} > /var/lib/cpu-governor/request"`
          )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• install-system-helper.sh

  install-system-helper.sh

• locale/pl/LC_MESSAGES/cpu-governor.po

  locale/pl/LC_MESSAGES/cpu-governor.po

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:223

              cpuInfoLabel = new St.Label({
                  text: '--',
                  y_align: Clutter.ActorAlign.CENTER,
                  style: `padding-left: ${paddingLeft}px; padding-right: ${paddingRight}px;`,
              })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:509

          notification.connect('activated', () => {
              this.openPreferences();
          })