Review of "CPU Governor" version 3

Details Page Preview

Quick Settings toggle for CPU governor

Extension Homepage
https://github.com/Rubikexe/cpu-governor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install-system-helper.sh
    install-system-helper.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:246
                cpuInfoLabel = new St.Label({
                    text: '--',
                    y_align: Clutter.ActorAlign.CENTER,
                    style: `padding-left: ${paddingLeft}px; padding-right: ${paddingRight}px;`,
                })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected