Review of "Loft Shell Helper" version 1.1 (2)

Details Page Preview

Window management helper for Loft — handles window activation and hides minimized Loft windows from alt-tab.

Extension Homepage
https://github.com/keithvassallomt/loft

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:637
                dndBtn.connect('clicked', () => {
                    this._callDaemonMethod(dbusName, 'SetDnd', '(b)', [!svc.dnd]);
                })
  • extension.js:324
            dndItem.connect('toggled', (_item, state) => {
                this._callDaemonMethod(dbusServiceName, 'SetDnd', '(b)', [state]);
            })
  • extension.js:295
            icon.connect('notify::allocation', () => {
                badge.set_position(
                    icon.x + icon.width - DOT_SIZE,
                    icon.y + icon.height - DOT_SIZE
                );
                dndBadge.set_position(
                    icon.x + icon.width - DASH_W,
                    icon.y + 
  • extension.js:492
            icon.connect('notify::allocation', () => {
                badge.set_position(
                    icon.x + icon.width - DOT_SIZE,
                    icon.y + icon.height - DOT_SIZE
                );
                dndBadge.set_position(
                    icon.x + icon.width - DASH_W,
                    icon.y + 
  • extension.js:649
                quitBtn.connect('clicked', () => {
                    this._callDaemonMethod(dbusName, 'Quit');
                    menu.close();
                })
  • extension.js:623
                showHideBtn.connect('clicked', () => {
                    this._callDaemonMethod(dbusName, 'Toggle');
                    menu.close();
                })

EGO014 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:506
    this._combinedBadge = badge
  • extension.js:507
    this._combinedDndBadge = dndBadge

All Versions

Version Status
1.3 (6) Active
1.1 (5) Active
1.1 (4) Rejected
1.1 (3) Rejected
1.1 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

Keith Vassallo auto- rejected
Auto-rejected because of new version 1.1 (3) was uploaded