EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• po/POTFILES

  po/POTFILES

• po/LINGUAS

  po/LINGUAS

• po/monitor-control.pot

  po/monitor-control.pot

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:428

      this._settings.connect('changed::ddcutil-extra-args', () => {
        _DdcutilWrapper.additionalArgs = this._parseExtraArgs(
          this._settings.get_string('ddcutil-extra-args'))
      })

• extension.js:432

      this._settings.connect('changed::ddcutil-path', () => {
        _DdcutilWrapper.binaryPath = this._settings.get_string('ddcutil-path').trim()
      })

• extension.js:425

      this._settings.connect('changed::ddcutil-sleep-multiplier', () => {
        _DdcutilWrapper.sleepMultiplier = this._settings.get_double('ddcutil-sleep-multiplier')
      })

• extension.js:402

  this._settings.connect('changed::show-brightness', this._showBrightnessSetting.bind(this))

• extension.js:403

  this._settings.connect('changed::show-volume', this._showVolumeSetting.bind(this))

• extension.js:404

      this._settings.connect('changed::unify-volume', () => {
        if (this._settings.get_boolean('unify-volume')) {
          this._saveSystemVolume()
          if (this._volumeAvailable)
            this._setSystemVolume100()
        } else {
          this._restoreSystemVolume()
        }
      })