GNOME Shell Extensions

Review of "MonitorControl - Brightness and Volume" version 2

Details Page Preview

MonitorControl - Brightness and Volume

by ahmed_shaalan

High-performance brightness and volume control for monitors using ddcutil. Optimized for speed and responsiveness.

Extension Homepage
https://github.com/AhmedShaalan/monitor-control-gnome-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:425 
    this._settings.connect('changed::show-brightness', this._showBrightnessSetting.bind(this))

All Versions

Version Status
2 Unreviewed
1 Rejected