Review of "Desktop Widgets" version 4

Details Page Preview

A modular widget system for your desktop. Place and customize various widgets on your background to enhance your workspace. Extension Homepage: https://github.com/NiffirgkcaJ/desktop-widgets https://gitlab.com/NiffirgkcaJ/desktop-widgets

Extension Homepage
https://github.com/NiffirgkcaJ/desktop-widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • shared/services/servicePluginRegistry.js:53
    metaFile.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • plugins/customtext/settings.js
  • plugins/customtext/widget.js
  • plugins/datetime/settings.js
  • plugins/datetime/widget.js
  • shared/settings/settingsBaseStyle.js
  • shared/utilities/utilityDateFormat.js
  • shared/utilities/utilityIconSt.js

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:31
            this._container = new St.Widget({
                name: 'DesktopWidgetsCanvas',
                reactive: false,
                x: monitor.x,
                y: monitor.y,
                width: monitor.width,
                height: monitor.height,
            })

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

dlandau active
Please check shexli messages for next time