Review of "Studi Brightness Control" version 7

Details Page Preview

Native GNOME integration for controlling Apple Studio Display brightness via studi or asdbctl. Note: You need to have either CLI tool(s) installed for this to work.

Extension Homepage
https://github.com/matey-0/Studi-Brightness-Control/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:78
            this.slider.connect('notify::value', () => {
                if (this._isInternalUpdate) return;
    
                const percentage = Math.round(this.slider.value * 100);
    
                if (this._updateTimeoutId) {
                    this._pendingValue = percentage;
                    return;
                }
    
    

All Versions

Version Status
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active