Review of "Better Desktop Zoom" version 13

Details Page Preview

A better experience with the GNOME magnifier

Extension Homepage
https://github.com/popov895/better-desktop-zoom

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:24
            this._a11ySettings = new Gio.Settings({
                schema_id: `org.gnome.desktop.a11y.applications`,
            })
  • extension.js:27
            this._magnifierSettings = new Gio.Settings({
                schema_id: `org.gnome.desktop.a11y.magnifier`,
            })

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • prefs.js:37
            keyController.connect(`key-pressed`, (...[, keyval, keycode, state]) => {
                switch (keyval) {
                    case Gdk.KEY_Escape: {
                        this.close();
                        return Gdk.EVENT_STOP;
                    }
                    case Gdk.KEY_BackSpace: {
                

All Versions

Version Status
13 Unreviewed
12 Unreviewed
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active