Review of "Auto-cpufreq Switcher" version 4

Details Page Preview

Simple governor switcher Gnome-Shell-Extension for auto-cpufreq

Extension Homepage
https://github.com/EBendinelli/auto-cpufreq-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:56
    this._governorSection = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:56
    this._governorSection = new PopupMenu.PopupMenuSection()

All Versions

Version Status
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active