Review of "Dock: Reloaded" version 11

Details Page Preview

Few tweaks for GNOME Dock: - moves it top - autohide ---> !reveals under cursor pressure! <--- - shows only favorites apps

Extension Homepage
https://github.com/martinpl/dock-reloaded

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:28
                this._itemDragBeginSignal = Main.overview.connect("item-drag-begin", () => {
                    this._dragging = true
                })
  • extension.js:31
                this._itemDragEndSignal = Main.overview.connect("item-drag-end", () => {
                    this._dragging = false
                })
  • extension.js:38
    this._pressureBarrier.connect("trigger", () => this._revealDock(true))
  • extension.js:17
    this.showAppsButton.connect("button-release-event", this._showAppsToggle.bind())

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:58
                this._revealTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 550, () => {
                    if (!this._dragging && !this.get_hover()) {
                        this.hide()
                        return GLib.SOURCE_REMOVE
                    } else {
                        return GLib.SOURCE_CONTINUE
      

All Versions

Version Status
11 Unreviewed
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected