Review of "Containers" version 40

Details Page Preview

Manage podman containers through a gnome-shell menu

Extension Homepage
https://github.com/rgolangh/gnome-shell-extension-containers

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:30
    Extension.lookupByUUID("containers@royg")

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:367
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • modules/podman.js:38
    console.error(e.message)
  • modules/podman.js:196
    console.error(e.message)
  • modules/podman.js:281
    console.error(`${errMsg}: ${e.message}`)
  • modules/podman.js:313
    console.error(`${errMsg}: ${e.message}`)
  • modules/podman.js:338
    console.error(e.message)
  • modules/podman.js:366
    console.error(`json parse error ${e}`)
  • modules/podman.js:371
    console.error(`Error reading stream: ${e}`)
  • modules/podman.js:204
    console.warn("unable to set podman info, will fall back to syntax and output < 2.0.3")

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:69
    this._containerSection = new PopupMenu.PopupMenuSection()
  • extension.js:86
    this._noContainersItem = new PopupMenu.PopupMenuItem("No containers detected")
  • extension.js:76
            this._scrollItem = new PopupMenu.PopupBaseMenuItem({
                reactive: true,
                can_focus: false,
                style_class: "containers-scroll-item",
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36
            this._indicator.menu.connect("open-state-changed", () => {
                if (this.menu.isOpen) {
                    this._renderMenu();
                    this._sync();
                } else {
                    this._stop_sync();
                }
            })
  • extension.js:240
            this.menu.connect("open-state-changed", (menu, open) => {
                if (open) {
                    this._populateSubmenu();
                }
            })

All Versions

Version Status
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Rejected
27 Inactive
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Inactive

Previous Reviews on this Version

fmuellner active