Review of "OTP keys" version 1.1.2 (33)

Details Page Preview

Show and copy otp keys Features * Show and search otp codes on panel menu * Copy codes to clipboards * Supports SHA1, SHA256, SHA512 algoritms * 30 and 60 seconds epoc time * 6 - 8 digits options * Import and export with otpauth://... and import with otpauth-migration://... links * Import QR from a camera or an image file

Extension Homepage
https://github.com/osmank3/otp-keys

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:112
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:150
            this._changedId =
                this._settings.connect(`changed::${SETTINGS_OTP_LIST}`,
                    () => this._fillList())

All Versions

Version Status
1.1.2 (33) Active
1.1.1 (32) Rejected
1.1.0 (31) Rejected
1.1.0 (30) Rejected
1.0.2 (29) Active
1.0.1 (28) Active
1.0.0 (27) Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Inactive
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

osmank3 posted a review
About shexli warning message I already add disconnecting signal on 302-304 lines, I guess shexli did not recognize it.
fmuellner active