EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• prefs.js:113

        restoreButton.connect('clicked', () => {
          appStoreCommandRow.set_text(defaultAppStoreCommand);
          clearEntryFocus();
        })

• prefs.js:118

        acceptButton.connect('clicked', () => {
          clearEntryFocus();
        })

• prefs.js:200

        labelRestoreButton.connect('clicked', () => {
          customMenuLabelRow.set_text(defaultMenuLabel);
          clearLabelFocus();
        })

• prefs.js:205

        labelAcceptButton.connect('clicked', () => {
          clearLabelFocus();
        })

• prefs.js:279

        commandRestoreButton.connect('clicked', () => {
          customMenuCommandRow.set_text(defaultMenuCommand);
          clearCommandFocus();
        })

• prefs.js:284

        commandAcceptButton.connect('clicked', () => {
          clearCommandFocus();
        })

• prefs.js:136

        focusController.connect('enter', () => {
          acceptButton.set_visible(true);
        })

• prefs.js:223

        labelFocusController.connect('enter', () => {
          labelAcceptButton.set_visible(true);
        })

• prefs.js:302

        commandFocusController.connect('enter', () => {
          commandAcceptButton.set_visible(true);
        })

• prefs.js:126

        keyController.connect('key-pressed', (controller, keyval) => {
          if (keyval === Gdk.KEY_Escape) {
            clearEntryFocus();
            return true;
          }
          return false;
        })

• prefs.js:213

        labelKeyController.connect('key-pressed', (controller, keyval) => {
          if (keyval === Gdk.KEY_Escape) {
            clearLabelFocus();
            return true;
          }
          return false;
        })

• prefs.js:292

        commandKeyController.connect('key-pressed', (controller, keyval) => {
          if (keyval === Gdk.KEY_Escape) {
            clearCommandFocus();
            return true;
          }
          return false;
        })

• prefs.js:139

        focusController.connect('leave', () => {
          acceptButton.set_visible(false);
        })

• prefs.js:226

        labelFocusController.connect('leave', () => {
          labelAcceptButton.set_visible(false);
        })

• prefs.js:305

        commandFocusController.connect('leave', () => {
          commandAcceptButton.set_visible(false);
        })

• prefs.js:395

          toggle.connect('notify::active', (widget) => {
            this._settings.set_boolean(key, widget.get_active());
          })

• prefs.js:413

        activityMenuSwitch.connect('notify::active', (widget) => {
          this._settings.set_boolean('activity-menu-visibility', !widget.get_active());
        })

• prefs.js:315

        customMenuExpanderRow.connect('notify::enable-expansion', (widget) => {
          const isEnabled = widget.get_enable_expansion();
          this._settings.set_boolean('custom-menu-enabled', isEnabled);
        })

• prefs.js:402

        iconSelectorRow.connect('notify::selected', (widget) => {
          this._settings.set_int('icon', widget.selected);
        })

• prefs.js:122

  appStoreCommandRow.connect('notify::text', updateRestoreButtonState)

• prefs.js:209

  customMenuLabelRow.connect('notify::text', updateLabelRestoreButtonState)

• prefs.js:288

  customMenuCommandRow.connect('notify::text', updateCommandRestoreButtonState)

• src/forceQuitOverlay.js:109

  this._capture.connect('captured-event', (_capture, event) => this._onEvent(event))

• src/forceQuitOverlay.js:110

  this._capture.connect('stop', () => this.emit('stop'))

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• src/kiwimenu.js:24

  file.load_contents(null)

• src/recentItemsSubmenu.js:855

  file.load_contents(null)

• src/recentItemsSubmenu.js:982

  file.load_contents(null)