Review of "Kiwi Menu" version 1.5.9 (21)

Details Page Preview

macOS-inspired quick menu for GNOME ## Features * Recent Items * Power menu * Hide Quicksettings buttons * Hide Activities buttons * Custom App Store Command * One Personalized Menu Item * macOS style user switcher * Multilingual support

Extension Homepage
https://github.com/kem-a/kiwi-menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • src/forceQuitOverlay.js:109
    this._capture.connect('captured-event', (_capture, event) => this._onEvent(event))
  • src/forceQuitOverlay.js:110
    this._capture.connect('stop', () => this.emit('stop'))

All Versions

Version Status
1.5.9 (21) Active
1.5.8 (20) Rejected
1.5.8 (19) Rejected
1.5.7 (18) Active
1.5.7 (17) Inactive
1.5.6 (16) Active
1.5.6 (15) Rejected
1.5.5 (14) Active
1.5.4 (13) Active
1.5.2 (12) Active
1.5.1 (11) Active
1.5.0 (10) Active
1.5.0 (9) Rejected
1.4.0 (8) Active
1.3.0 (7) Active
1.3.0 (6) Rejected
1.2.0 (5) Active
1.1.1 (4) Active
1.1.0 (3) Active
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

Arnis K posted a review
EGO-L-003 - this is false positive. The signals are always disconnected when the capture ends via disconnectAll() at line 64. There is no enable()/disable() lifecycle involved with these objects
dlandau active