Review of "Dock Media Player" version 1.3 (6)

Details Page Preview

Simple media widget for Dash to Dock

Extension Homepage
https://github.com/pajgla/Gnome-Dock-Media-Player

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:109
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                const iconSize = dash.iconSize ?? 32;
                this._mediaWidget._albumCoverArt.set_size(iconSize, iconSize);
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1.3 (6) Active
1.2 (5) Active
1.1 (4) Active
1.0 (3) Active
1.0 (2) Rejected
1 Rejected

Previous Reviews on this Version

Pajgla posted a review
Sorry for the bulk of changes! I took some time to investigate how other extensions work and I was fighting with bugs I had with my extension, so with the new Gnome 50, I wanted to pack all the changes I had into a new version. If it gets too hard to review, please do say, I will try to split it into multiple versions. Thanks!
fmuellner active