Review of "GnomeVantage" version 1.0 (1)

Details Page Preview

Control features of your Lenovo Legion or Ideapad laptop such as battery fast charging, conservation mode, hybrid graphics and more.

Extension Homepage
https://github.com/unaibenidorm/gnomevantage

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • util/install-passwordless.sh
    util/install-passwordless.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:284
            this._interfaceSignalId = this._interfaceSettings.connect(
                `changed::${COLOR_SCHEME_KEY}`, () => this._updatePanelIcon()
            )
  • extension.js:295
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen)
                    this._refreshAll();
            })
  • extension.js:276
    this._settings.connect(
                    'changed::show-top-bar-icon', () => this._updateTopBarVisibility()
                )

All Versions

Version Status
2.0 (3) Unreviewed
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

unaibenidorm posted a review
unaibenidorm auto- rejected
Auto-rejected because of new version 1.0 (2) was uploaded