Review of "GnomeVantage" version 1.0 (2)

Details Page Preview

Control features of your Lenovo Legion or Ideapad laptop such as battery fast charging, conservation mode, hybrid graphics and more.

Extension Homepage
https://github.com/unaibenidorm/gnomevantage

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:286
            this._interfaceSignalId = this._interfaceSettings.connect(
                `changed::${COLOR_SCHEME_KEY}`, () => this._updatePanelIcon()
            )
  • extension.js:297
            this._menuOpenSignalId = this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen)
                    this._refreshAll();
            })
  • extension.js:281
                this._panelIconSignalId = this._settings.connect(
                    'changed::panel-icon-name', () => this._updatePanelIcon()
                )
  • extension.js:278
                this._showTopBarSignalId = this._settings.connect(
                    'changed::show-top-bar-icon', () => this._updateTopBarVisibility()
                )

All Versions

Version Status
2.0 (3) Unreviewed
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

unaibenidorm auto- rejected
Auto-rejected because of new version 2.0 (3) was uploaded