Review of "Immich Wallpaper" version 10

Details Page Preview

Sets desktop wallpaper from Immich server photos

Extension Homepage
https://github.com/nokichan/immich-gnome-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 41 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:17
    console.log('Enabling Immich Wallpaper extension')
  • extension.js:55
    console.log('Disabling Immich Wallpaper extension')
  • extension.js:191
    console.log(`Immich Wallpaper: Authentication failed - ${errorMessage || 'Unknown error'}`)
  • extension.js:207
    console.log('Immich Wallpaper: Retrying authentication...')
  • extension.js:232
    console.log('Immich Wallpaper: Missing configuration')
  • extension.js:247
    console.log('Immich Wallpaper: Invalid server URL')
  • extension.js:252
    console.log(`Immich Wallpaper: Error creating request: ${e}`)
  • extension.js:277
    console.log('Immich Wallpaper: Empty response from server')
  • extension.js:290
    console.log(`Immich Wallpaper: Invalid JSON response: ${parseError}`)
  • extension.js:296
    console.log('Immich Wallpaper: No access token in response')

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:105
            this._descriptionItem = new PopupMenu.PopupMenuItem('No photo loaded', {
                reactive: false,
                style_class: 'immich-description-item',
            })
  • extension.js:116
    this._locationItem = new PopupMenu.PopupMenuItem('No location available')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:105
            this._descriptionItem = new PopupMenu.PopupMenuItem('No photo loaded', {
                reactive: false,
                style_class: 'immich-description-item',
            })
  • extension.js:116
    this._locationItem = new PopupMenu.PopupMenuItem('No location available')

All Versions

Version Status
14 Active
13 Active
12 Inactive
11 Inactive
10 Rejected
9 Inactive
8 Rejected
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

review auto- rejected
Auto-rejected because of new version 11 was uploaded