Review of "Immich Wallpaper" version 15

Details Page Preview

Sets desktop wallpaper from Immich server photos

Extension Homepage
https://github.com/nokichan/immich-gnome-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:698
                this._notificationSource.connect('destroy', () => {
                    this._notificationSource = null;
                })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:617
            GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                try {
                    let backgroundSettings = new Gio.Settings({
                        schema: 'org.gnome.desktop.background'
                    });
                    
                    let pictureOptions = this._settings.get_string('pict

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
16 Active
15 Rejected
14 Active
13 Inactive
12 Inactive
11 Inactive
10 Rejected
9 Inactive
8 Rejected
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

review auto- rejected
Auto-rejected because of new version 16 was uploaded