Review of "Alt-Tab MRU Window Switcher" version 6

Details Page Preview

Windows-style Alt+Tab for GNOME with true MRU ordering and icon-only display

Extension Homepage
https://miranova.studio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.alt-tab-mru.gschema.xml
    id='org.gnome.shell.extensions.alt-tab-mru-switcher' path='/org/gnome/shell/extensions/alt-tab-mru-switcher/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:356
    iconBin

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:362
            this._overlay.connect('notify::width', () => {
                const m = Main.layoutManager.primaryMonitor;
                this._overlay.set_position(
                    Math.floor(m.x + (m.width - this._overlay.width) / 2),
                    Math.floor(m.y + (m.height - this._overlay.height) / 2),
        

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:190
            GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                if (this._isValidWindow(window)) {
                    this._promoteWindow(window);
                    this._trackWindowDestroy(window);
                }
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active