Review of "Gravatar" version 10

Details Page Preview

Synchronize GNOME Shell user icon with an avatar service, one of Gravatar or Libravatar. This extension is not affiliated, funded, or in any way associated with Automattic or Gravatar.

Extension Homepage
https://github.com/dsheeler/gnome-shell-extensions-gravatar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 65% of identifiers are 1–2 characters (avg length 2.8).

Code must not be obfuscated

  • lib/md5.js
    short identifier ratio: 65%, identifiers scored: 599

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • extension.js:20
    this.settings = this.getSettings()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:20
    this.settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:268
    this.notifSource.connect('destroy', ()=>{this.notifSource = null;})

All Versions

Version Status
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active