Review of "WARP Toggle" version 8

Details Page Preview

Toggle Cloudflare WARP connection from Quick Settings menu

Extension Homepage
https://github.com/mrvladus/warp-toggle-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • ui/quickToggle.js:103
            this._refreshButton = new St.Button({
              style_class: 'icon-button',
              child: new St.Icon({ iconName: 'view-refresh-symbolic' }),
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:56
    this._settings = this.getSettings()
  • ui/quickToggle.js:103
            this._refreshButton = new St.Button({
              style_class: 'icon-button',
              child: new St.Icon({ iconName: 'view-refresh-symbolic' }),
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • ui/quickToggle.js:107
            this._refreshButton.connect('clicked', () => {
              this._handleRefreshClicked();
            })

All Versions

Version Status
8 Unreviewed
7 Active
6 Active
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected