Review of "Per-Monitor Screen Blank" version 1

Details Page Preview

Blank individual monitors after pointer idle time.

Extension Homepage
https://github.com/nikitakarpei/per-monitor-screen-blank

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • src/domain/DomainEngine.js
  • src/domain/activityPolicy.js
  • src/platform/ShellRuntimeProbe.js
  • src/ui/indicator.js

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:67
                    GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                        resolve();
                        return GLib.SOURCE_REMOVE;
                    })

All Versions

Version Status
8 Unreviewed
7 Rejected
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Nikita Karpei auto- rejected
Auto-rejected because of new version 2 was uploaded