Review of "Per-Monitor Screen Blank" version 10

Details Page Preview

Blank individual monitors after pointer idle time. Preferences include diagnostics that can open/read extension logs and run journalctl in a terminal.

Extension Homepage
https://github.com/nikitakarpei/per-monitor-screen-blank

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.per-monitor-screen-blank.gschema.xml
    id='org.gnome.shell.extensions.per-monitor-screen-blank.profile' path=''

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.per-monitor-screen-blank.gschema.xml
    id='org.gnome.shell.extensions.per-monitor-screen-blank.profile' path=''

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-pointer-context-menu.js:24
    this.#menuManager = new PopupMenu.PopupMenuManager(this.#anchor)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-pointer-context-menu.js:12
            this.#anchor = new St.Widget({
                reactive: true,
                width: 1,
                height: 1,
                x: 0,
                y: 0,
            })
  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-pointer-context-menu.js:20
    this.#menu = new PopupMenu.PopupMenu(this.#anchor, 0, St.Side.TOP)
  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-pointer-context-menu.js:24
    this.#menuManager = new PopupMenu.PopupMenuManager(this.#anchor)
  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-quick-settings.js:16
    this.#indicator = new QuickSettings.SystemIndicator()
  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-quick-settings.js:28
    this.#profileSection = new PopupMenu.PopupMenuSection()
  • platforms/gnome/packages/gnome-shell/src/shell-ui/gnome-quick-settings.js:17
            this.#toggle = new QuickSettings.QuickMenuToggle({
                iconName: 'display-symbolic',
                title: 'Screen Blank',
            })

All Versions

Version Status
10 Unreviewed
9 Rejected
8 Rejected
7 Rejected
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected