Review of "Aare Guru" version 9

Details Page Preview

Display water temperature and flow information from aareguru.existenz.ch, the API for aare.guru, in your GNOME Shell panel

Extension Homepage
https://github.com/jon4hz/gnome-shell-extension-aareguru

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:51
                this._settings.connect('changed::city', () => {
                    this._updateData();
                })
  • extension.js:63
                this._settings.connect('changed::show-flow-section', () => {
                    this._rebuildMenu();
                })
  • extension.js:67
                this._settings.connect('changed::show-schwimmkanal-section', () => {
                    this._rebuildMenu();
                })
  • extension.js:59
                this._settings.connect('changed::show-temperature-section', () => {
                    this._rebuildMenu();
                })
  • extension.js:71
                this._settings.connect('changed::show-weather-section', () => {
                    this._rebuildMenu();
                })
  • extension.js:55
                this._settings.connect('changed::update-interval', () => {
                    this._scheduleUpdate();
                })

All Versions

Version Status
9 Active
8 Active
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active