Review of "Undecorate Window" version 15

Details Page Preview

Add undecorate item in window menu. Use ALT+Space to show window menu.

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-undecorate

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:35
            GLib.spawn_command_line_sync('xprop -id ' + activeWindowId(window)
                + ' -f _MOTIF_WM_HINTS 32c -set'
                + ' _MOTIF_WM_HINTS "0x2, 0x0, 0x0, 0x0, 0x0"')
  • extension.js:45
            GLib.spawn_command_line_sync('xprop -id ' + activeWindowId(window)
                + ' -f _MOTIF_WM_HINTS 32c -set'
                + ' _MOTIF_WM_HINTS "0x2, 0x0, 0x1, 0x0, 0x0"')

All Versions

Version Status
15 Active
14 Active
13 Active
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Active
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Active
1 Inactive

Previous Reviews on this Version

fmuellner active
Probably worth mentioning somewhere user-visible that this only works for xwayland windows