Review of "Grimble Tiling WM" version 7

Details Page Preview

You like GNOME? You like Tiling Window Managers? You can now have the best of both worlds with Grimble, the GNOME tiling window manager extension.

Extension Homepage
https://github.com/erwanlem/grimble-tiling-wm

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • tile.js:179
    this._window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tile.js:199
    this._window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tileWindowManager.js:331
    window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tileWindowManager.js:338
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • tileWindowManager.js:969
    file.load_contents(null)
  • tileWindowManager.js:1005
    file.load_contents(null)

All Versions

Version Status
8 Unreviewed
7 Rejected
6 Active
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

air_one auto- rejected
Auto-rejected because of new version 8 was uploaded