GNOME Shell Extensions

Review of "Grimble Tiling WM" version 8

Details Page Preview

Grimble Tiling WM

by erwan_lmt

You like GNOME? You like Tiling Window Managers? You can now have the best of both worlds with Grimble, the GNOME tiling window manager extension.

Extension Homepage
https://github.com/erwanlem/grimble-tiling-wm
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • tile.js:180 
    this._window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tile.js:206 
    this._window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tileWindowManager.js:328 
    window.unmaximize(Meta.MaximizeFlags.BOTH)
  • tileWindowManager.js:341 
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • tileWindowManager.js:976 
    file.load_contents(null)

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
For the warning mentioned in Shexli: [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async)
air_one posted a review
Thanks! About the error with the maximize argument, I followed the "Targeting Older GNOME Versions" page but Shexli still gives an error. Just to be sure, I can keep it like this?
JustPerfection posted a review
You should version check for that: https://gjs.guide/extensions/upgrading/gnome-shell-40.html#checking-gnome-shell-version Still, it will give you the false positive error.