Review of "Syncthing Toggle" version 10

Details Page Preview

A GNOME quick setting for turning on and off the Syncthing service and opening the Web GUI

Extension Homepage
https://github.com/rehhouari/gnome-shell-extension-syncthing-toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • toggle.js:29
    this._itemsSection = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • toggle.js:29
    this._itemsSection = new PopupMenu.PopupMenuSection()
  • toggle.js:26
    this._settings = extensionObject.getSettings()

All Versions

Version Status
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active