Review of "Simple Message" version 26

Details Page Preview

Print a custom message on the top bar.

Extension Homepage
https://github.com/freddez/gnome-shell-simple-message

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:107
                this._handler_id = this._settings.connect(
                    "changed::message",
                    this._rewriteMessage.bind(this),
                )
  • extension.js:111
                this._settings.connect(
                    "changed::command",
                    this._rewriteCommand.bind(this),
                )
  • extension.js:115
                this._settings.connect(
                    "changed::font-size",
                    this._rewriteFontsize.bind(this),
                )
  • extension.js:119
                this._settings.connect(
                    "changed::panel-alignment",
                    this._moveMessage.bind(this),
                )
  • extension.js:123
                this._settings.connect(
                    "changed::panel-position",
                    this._moveMessage.bind(this),
                )

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:101
                GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                    this._moveMessage();
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
27 Active
26 Rejected
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Inactive
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

fredz auto- rejected
Auto-rejected because of new version 27 was uploaded