Review of "Saturation Extension" version 5

Details Page Preview

Adjust the saturation or hue of the screen.

Extension Homepage
https://github.com/zb3/gnome-saturation-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:24
    Main.layoutManager.uiGroup.connect('destroy', () => (this._effect = null))

All Versions

Version Status
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active