EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• lib/torController.js:130

  file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• ui/quickToggle.js:194

  console.warn(`[tor-ext] toggle failed: ${e.message}`)

• ui/quickToggle.js:274

  console.warn(`[tor-ext] tun2socks stop step failed/timed out: ${e.message}`)

• ui/quickToggle.js:285

  console.warn(`[tor-ext] controller.quit timed out: ${e.message}`)

• ui/quickToggle.js:293

  console.warn(`[tor-ext] service.stop timed out: ${e.message}`)

• ui/quickToggle.js:369

  console.warn(`[tor-ext] SETEVENTS failed: ${e.message}`)

• ui/quickToggle.js:500

  console.warn(`[tor-ext] setConf ExitNodes failed: ${e.message}`)

• ui/quickToggle.js:98

  console.log(`[tor-ext] services rebuilt for systemMode=${want}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• ui/quickToggle.js:142

          this._menuOpenId = this.menu.connect('open-state-changed', (_m, open) => {
              if (open && this.checked && this._controller?.isReady)
                  this._refreshCircuitView();
          })