EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• lib/torController.js:130

  file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• ui/quickToggle.js:105

  console.log(`[tor-ext] tun2socks side service ${want ? 'enabled' : 'disabled'}`)

• ui/quickToggle.js:223

  console.warn(`[tor-ext] toggle failed: ${e.message}`)

• ui/quickToggle.js:303

  console.warn(`[tor-ext] tun2socks stop step failed/timed out: ${e.message}`)

• ui/quickToggle.js:314

  console.warn(`[tor-ext] controller.quit timed out: ${e.message}`)

• ui/quickToggle.js:322

  console.warn(`[tor-ext] service.stop timed out: ${e.message}`)

• ui/quickToggle.js:397

  console.warn(`[tor-ext] SETEVENTS failed: ${e.message}`)

• ui/quickToggle.js:527

  console.warn(`[tor-ext] setConf ExitNodes failed: ${e.message}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• ui/quickToggle.js:171

          this._menuOpenId = this.menu.connect('open-state-changed', (_m, open) => {
              if (open && this.checked && this._controller?.isReady)
                  this._refreshCircuitView();
          })