Review of "Transmission Daemon Indicator NG" version 2.6.0 (13)

Details Page Preview

Monitor and control transmission-daemon or transmission-gtk. The extension use the Transmission RPC protocol for interacting with it. Fragments 2.0 user also can use this extension because it is a frontend for transmission-daemon. This extension is only for Gnome Shell version major or equal to 43 because it use libsoup3.

Extension Homepage
https://gitlab.gnome.org/glerro/gnome-shell-extension-transmission-daemon-ng

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:298
    console.log(`${this._extensionName} - Invalid response to processList: ${message.status_code} = ${message.reason_phrase}`)
  • extension.js:356
    console.log(`${this._extensionName} - Invalid response to processSession: ${message.status_code} = ${message.reason_phrase}`)
  • extension.js:390
    console.log(`${this._extensionName} - Session Action Error: ${response}`)
  • extension.js:401
    console.log(`${this._extensionName} - Torrent Action Error: ${response}`)
  • extension.js:429
    console.log(`${this._extensionName}: Daemon Monitor - Destroying....bye bye`)
  • extension.js:1735
    console.log(`Enabling ${this.metadata.name} - Version ${this.metadata['version-name']}`)
  • extension.js:1744
    console.log(`Disabling ${this.metadata.name} - Version ${this.metadata['version-name']}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:1488
            this.actor = new St.Button({
                style_class: 'modal-dialog-button button',
                child: this.icon,
            })
  • extension.js:1480
            this.icon = new St.Icon({
                icon_name: '%s-symbolic'.format(icon),
                icon_size: iconSize,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:122
    this._settings = extension.getSettings()
  • extension.js:1488
            this.actor = new St.Button({
                style_class: 'modal-dialog-button button',
                child: this.icon,
            })
  • extension.js:1480
            this.icon = new St.Icon({
                icon_name: '%s-symbolic'.format(icon),
                icon_size: iconSize,
            })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:132
    this._httpSession = new Soup.Session()

All Versions

Version Status
2.6.0 (13) Active
2.5.0 (12) Active
2.4.1 (11) Active
2.4.0 (10) Active
2.3.0 (9) Active
8 Active
7 Inactive
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active