Review of "Free Space Indicator" version 1.1.0 (4)

Details Page Preview

Shows disk free space in the top panel

Extension Homepage
https://github.com/inbalboa/gnome-freespace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:45
    console.error('Error initializing disk info:', e)
  • extension.js:114
    console.error('Error refreshing disk info:', e)
  • extension.js:134
    console.error('Error refreshing disk info on settings change:', e)
  • extension.js:219
    console.error('Error getting mount points:', e)
  • extension.js:250
    console.error('Error getting mount point source device:', e)
  • extension.js:265
    console.error('Error getting disk space:', e)
  • extension.js:397
    console.error('Error during monitoring refresh:', e)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:59
    this._settings.connect('changed', this._onSettingsChanged.bind(this))

All Versions

Version Status
1.3.2 (7) Active
1.3.1 (6) Active
1.1.1 (5) Active
1.1.0 (4) Rejected
1.0.3 (3) Active
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

inbalboa auto- rejected
Auto-rejected because of new version 1.1.1 (5) was uploaded