Review of "Free Space Indicator" version 1.3.2 (7)

Details Page Preview

Shows disk free space in the top panel

Extension Homepage
https://github.com/inbalboa/gnome-freespace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:60
    console.error(this._logPrefix, 'Error initializing disk info:', e)
  • extension.js:128
    console.error(this._logPrefix, 'Error refreshing disk info:', e)
  • extension.js:148
    console.error(this._logPrefix, 'Error refreshing disk info on settings change:', e)
  • extension.js:235
    console.error(this._logPrefix, 'Error getting mount points:', e)
  • extension.js:259
    console.error(this._logPrefix, 'Error getting disk space:', e)
  • extension.js:396
    console.error(this._logPrefix, 'Error during monitoring refresh:', e)

All Versions

Version Status
1.3.2 (7) Active
1.3.1 (6) Active
1.1.1 (5) Active
1.1.0 (4) Rejected
1.0.3 (3) Active
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection active
Approved but please avoid duplicated code: https://gjs.guide/extensions/review-guidelines/best-practices.html#use-helper-functions-instead-of-code-duplication