Review of "Linak/Idasen Desk Controller" version 4

Details Page Preview

Control your IKEA Idasen/Linak desk height with favorite positions from linak-controller config

Extension Homepage
https://github.com/p-gentili/linak-controller-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:67
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:126
    console.log(`Moving desk to position: ${position}`)
  • extension.js:140
    console.log(`Desk moved to position ${position} successfully`)
  • extension.js:141
    console.log('linak-controller output:', stdout)
  • extension.js:171
    console.log('Enabling Linak Controller extension')
  • extension.js:179
    console.log('Disabling Linak Controller extension')
  • extension.js:70
    console.error('Failed to load linak-controller config')
  • extension.js:78
    console.error('Error reading linak-controller config:', e)
  • extension.js:143
    console.error(`Failed to move desk to position ${position}`)
  • extension.js:144
    console.error('linak-controller error:', stderr)
  • extension.js:151
    console.error('Error executing linak-controller:', e)

All Versions

Version Status
4 Active
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

fmuellner active